Add optional time window in TraceGetParameters #6159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
rim99
force-pushed
the
optinal-time-window-when-fetching-trace-by-id
branch
2 times, most recently
from
17bddcc
to
cb5f24f
Compare
Signed-off-by: rim99 <[email protected]>
rim99
force-pushed
the
optinal-time-window-when-fetching-trace-by-id
branch
from
cb5f24f
to
d00b4d3
Compare
rim99
changed the title
Signed-off-by: rim99 <[email protected]>
Signed-off-by: Zhang Xin <[email protected]>
Signed-off-by: rim99 <[email protected]>
rim99
force-pushed
the
optinal-time-window-when-fetching-trace-by-id
branch
from
a0bb411
to
74fd1e5
Compare
yurishkuro
reviewed
Nov 17, 2024
| @@ -49,15 +50,27 @@ func unwrapNotFoundErr(err error) error { | |||
| } | |||
|
|
|||
| // QueryTrace queries for a trace and returns all spans inside it | |||
| func (q *Query) QueryTrace(traceID string) ([]model.Span, error) { | |||
| func (q *Query) QueryTrace(traceID string, startTime int64, endTime int64) ([]model.Span, error) { | |||
There was a problem hiding this comment.
we always try to use strong types. Conversion from user-facing values can be done at the user interface layer, not at this internal API.
Suggested change
| func (q *Query) QueryTrace(traceID string, startTime int64, endTime int64) ([]model.Span, error) { | |
| func (q *Query) QueryTrace(traceID string, startTime time.Time, endTime time.Time) ([]model.Span, error) { |
yurishkuro
reviewed
Nov 17, 2024
Comment on lines
+56
to
+57
| StartTime *time.Time | ||
| EndTime *time.Time |
There was a problem hiding this comment.
time.Time has IsZero that can be used as an indication of "value not provided", instead of pointers.
yurishkuro
reviewed
Nov 17, 2024
| @@ -50,6 +50,13 @@ type Reader interface { | |||
| FindTraceIDs(ctx context.Context, query *TraceQueryParameters) ([]model.TraceID, error) | |||
| } | |||
|
|
|||
| // TraceGetParameters contains parameters of a trace get. | |||
| type TraceGetParameters struct { | |||
There was a problem hiding this comment.
the name reads weird
Suggested change
| type TraceGetParameters struct { | |
| type GetTraceParameters struct { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #4150
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test